datacite / bracco

Frontend for the DataCite DOI Fabrica service
https://doi.datacite.org
MIT License
13 stars 8 forks source link

DOI Form - Unable to save due to schema 3 but no error #439

Closed richardhallett closed 4 years ago

richardhallett commented 4 years ago

If you have a DOI that is created using schema version 3 and attempt to say just update the DOI findable state, the FORM will not save, however it does not give you any error, it just won't let you save.

I think this maybe in general a problem with invalid metadata for the interface and not just schema version 3.

It's difficult to reproduce as copying existing bad data and resaving does seem to fix. I'd suggest at minimum we look into how we can present an error and potential fixes i.e. using the file upload and resaving raw xml perhaps.

Below is example metadata from what was a broken DOI:

<?xml version="1.0" encoding="UTF-8"?>
<resource xmlns="http://datacite.org/schema/kernel-3" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://datacite.org/schema/kernel-3 http://schema.datacite.org/meta/kernel-3/metadata.xsd">
   <identifier identifierType="DOI">10.4225/75/57982cdf31b4a</identifier>
   <publisher>Security Research Institute (SRI), Edith Cowan University</publisher>
   <publicationYear>2015</publicationYear>
   <resourceType resourceTypeGeneral="Text">Conference paper</resourceType>
   <titles>
      <title>Security of eprescription: Security of data at rest in prescription exchange services vs on mobile devices</title>
   </titles>
   <subjects>
      <subject subjectScheme="ANZRC FOR Code 080303">Computer System Security</subject>
   </subjects>
   <formats>
      <format>PDF</format>
   </formats>
   <descriptions>
      <description descriptionType="SeriesInformation">Proceedings of the 4th Australian eHealth Informatics and Security Conference, held from the 30 November – 2 December, 2015 at Edith Cowan University, Joondalup Campus, Perth, Western Australia.</description>
      <description descriptionType="Abstract">One area of healthcare that has moved more quickly than others in adopting electronic transfer of information is prescribing in the primary care environment. Several Acts and Regulations have been repealed and amended at Commonwealth and State levels to enable this progress over the past decade, as medication provision is a strictly controlled area of healthcare. Further, numerous standards and specifications have been developed and adopted to support and safeguard the regulatory changes and facilitate the electronic transfer of prescriptions. However, the current model of electronic prescription transfer comes with a substantial price tag for ongoing use. With the Nation’s growing and aging population, the number of prescriptions will increase annually, and thus it is necessary to find more cost-effective alternatives with comparable security and privacy assurances. An obvious potential solution lies in using devices that have been a part of our daily lives for well over a decade - mobile smartphones. An investigation was conducted to determine whether or not such technology is capable of meeting legislative requirements for prescribing whilst providing a cost-effective alternative prescription transfer model. Using technology such as near field communication for transfer process together with existing encryption technique demonstrates this can meet the security requirements of data at rest. This investigation established that although the proposed alternative is a work in progress and not a flawless one, it indeed opens up opportunities to incorporate many useful features in addition to eliminating the associated ongoing costs while providing comparable privacy and security assurances.</description>
   </descriptions>
   <creators>
      <creator>
         <creatorName>Htat, Kyaw Kyaw</creatorName>
         <affiliation>Edith Cowan University</affiliation>
      </creator>
      <creator>
         <creatorName>Williams, Patricia A.H.</creatorName>
         <affiliation>Edith Cowan University</affiliation>
      </creator>
      <creator>
         <creatorName>McCauley, Vincent</creatorName>
         <affiliation>Edith Cowan University</affiliation>
      </creator>
   </creators>
</resource>

It may be possible to reproduce by directly loading into the DB first rather than using the API.

mfenner commented 4 years ago

Reading schema 3 metadata is supported by bolognese. We should think about adding an error handler layer on top of what the XSD validations returns, which can be obscure and misleading.

mfenner commented 4 years ago

Which may also involve JSON Schema.

kjgarza commented 4 years ago

I can't reproduce this anymore (in Stage). Url gets update. Obviously the Form now transform the metadata to version 4. see: https://doi.stage.datacite.org/dois/10.4121%2Feb2z-8122