datacite / bracco

Frontend for the DataCite DOI Fabrica service
https://doi.datacite.org
MIT License
13 stars 8 forks source link

File Upload validation does not detect metadata error, text turns green #617

Open MaryHirsch opened 2 years ago

MaryHirsch commented 2 years ago

Expected Behaviour

When metadata is entered into the File Upload in Fabrica, the text turns red if there is an error (once the state is changed to "findable")

Current Behaviour

Some errors are not detected by the File Upload

Steps to Reproduce

  1. Log into Fabrica and click "Create File Upload"
  2. Change the state to Findable
  3. Paste in metadata with errors and note that metadata turns green but when clicking "Create" nothing happens

metadata example: {

          "@context": https://schema.org/,

          "@type": "Dataset",

          "@id": https://doi.org/10.57705/spg6-x549,

          "name": "Diabetes During COVID19",

          "description": "Deidientified demographics and selected medical history flags for patients with diabetes that had a visit in 2018, 2019, or 2020. Grouped by month.",

          "identifier": "2148",

          "url": https://resource.cctr.vcu.edu/resource/2148,

          "author": {

                         "@type": "Organization",

                         "name": "C. Kenneth and Dianne Wright Center for Clinical and Translational Research",

                         "sameAs": https://doi.org/10.13039/100009238

          },

          "citation": {

                         "@type": "CreativeWork",

                         "identifier": "10.1080/13602004.2021.2008868",

                         "url": https://doi.org/10.1080/13602004.2021.2008868,

                         "text": "Asmaa Namoos, Nour Eldin Abosamak, Maryam Abdelkarim, Rana Ramadan, Briona Phillips, Dina Ramadan, Mostafa Abdou \u0026 Tamas S. Gal (2021) Muslim Women and Disparities in Cancer Diagnosis: A Retrospective Study, Journal of Muslim Minority Affairs, 41:3, 541-547"

          },

          "creator": {

                         "@type": "Organization",

                         "name": "C. Kenneth and Dianne Wright Center for Clinical and Translational Research",

                         "url": https://cctr.vcu.edu/

          },

          "datePublished": "2022-03-22",

          "license": {

                         "@type": "CreativeWork",

                         "name": "VCU CUSTOM LICENSE",

                         "license": https://resource.cctr.vcu.edu/dataset/license

          },

          "publisher": {

                         "@type": "Organization",

                         "name": "Virginia Commonwealth University",

                         "sameAs": https://doi.org/10.13039/100009238

          },

          "version": "3/21/2022 10:55:20 PM"

}

Context (Environment)

Fabrica

Screenshots

Further details

Proposal

Hypothesis

Possible Implementation

Front logo Front conversations

MaryHirsch commented 2 years ago

Another example:

<?xml version="1.0" encoding="UTF-8"?>
<resource xsi:schemaLocation="http://datacite.org/schema/kernel-4 https://schema.datacite.org/meta/kernel-4.4/metadata.xsd">
    <identifier identifierType="DOI">10.20376/IDIOM-23665556.22.rn026.en</identifier>
    <creators>
        <creator>
            <creatorName>Nikolai Grube</creatorName>
            <nameIdentifier nameIdentifierScheme="GND" schemeURI="http://d-nb.info/gnd/">110726553</nameIdentifier>
            <affiliation>Rheinische Friedrich-Wilhelms-Universität, Bonn</affiliation>
        </creator>        
        <creator>
            <creatorName>Elisabeth Wagner</creatorName>
            <nameIdentifier nameIdentifierScheme="GND" schemeURI="http://d-nb.info/gnd/">1169848311</nameIdentifier>
            <affiliation>Rheinische Friedrich-Wilhelms-Universität, Bonn</affiliation>
        </creator>
        <creator>
            <creatorName>Christian Prager</creatorName>
            <nameIdentifier nameIdentifierScheme="GND" schemeURI="http://d-nb.info/gnd/">139962859</nameIdentifier>
            <affiliation>Rheinische Friedrich-Wilhelms-Universität, Bonn</affiliation>
        </creator>                    
        <creator>
            <creatorName>Marie Botzet</creatorName>
            <affiliation>Rheinische Friedrich-Wilhelms-Universität, Bonn</affiliation>
        </creator>
        <creator>
            <creatorName>Guido Krempel</creatorName>
            <affiliation>Rheinische Friedrich-Wilhelms-Universität, Bonn</affiliation>
        </creator>
    </creators>
    <titles>
        <title xml:lang="en">Pecking a New Stela: A Reading Proposal for Sign 1927st as T’OJ</title>
        <title xml:lang="en" titleType="Subtitle">Research Note 26</title>
    </titles>
    <publisher>Textdatenbank und Wörterbuch des Klassischen Maya</publisher>
    <publicationYear>2022</publicationYear>
    <subjects>
       <subject>Classic Mayan</subject>
    </subjects>
    <contributors>
        <contributor contributorType="ResearchGroup">
            <contributorName>Textdatenbank und Wörterbuch des Klassischen Maya</contributorName>
        </contributor>
    </contributors>
    <language>en</language>
    <resourceType resourceTypeGeneral="Text">Research Note</resourceType>
    <relatedIdentifiers>
        <relatedIdentifier relatedIdentifierType="ISSN" relationType="IsPartOf">2366-5556</relatedIdentifier>
    </relatedIdentifiers>
    <formats>
        <format>PDF</format>
    </formats>
    <rightsList>
        <rights rightsURI="http://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution 4.0 International</rights>
    </rightsList>
    <descriptions>
        <description xml:lang="en">
        Quirigua Stela C is among the best-known monuments of the Classic Maya. This is due to the much-cited account of the creation of the present world, inscribed on the east side of the monument (Freidel, Schele and Parker 1993; Looper 1995, 2003). From a historical perspective, however, the text on the opposite west side is also of interest, reporting on the reign of King Tutum Yohl K'inich, who erected a monument at Quirigua on the day 6 Ajaw 13 Yaxk'in (9.1.0.0.0, August 29, 455). The fact that this Early Classic event is mentioned on Stela C is related to the day 6 Ajaw, on which Stela C itself was erected by Quirigua's great king K'ahk' Tiliw Chan Yopaat, namely on the day 6 Ajaw 13 K'ayab (9.17.5.0.0, December 30, 775). However, in the past, little importance has been given to the two short basal texts on the front and back, each consisting of four hieroglyphic blocks.
        </description>
    </descriptions>
</resource>