datacite / datacite

Issues and milestones for the DataCite organization
https://www.datacite.org
MIT License
42 stars 8 forks source link

bibtex view does not render #400

Closed daslerr closed 6 years ago

daslerr commented 6 years ago

Client reports that for several of their DOIs, the bibtex view does not render in Fabrica. When viewing the individual DOI record in Fabrica, selecting other view options like DataCite XML or Citeproc JSON appropriately renders the metadata in the selected format, but selecting bibtex returns the view to summary view and the bibtex does not render.

Example DOIs: 10.5067/ADEOS-II/AMSR/AMSR-L1A.003 10.5067/ADEOS-II/AMSR/AA_L2A.001 10.5067/ALTCY-TJ122 10.5067/ASTER/AST14DEM.003

Front logo Front conversations

richardhallett commented 6 years ago

This appears not Fabrica specific but related to content-negotiation. Reproducing using a httpie call: http https://data.datacite.org/10.5067/ADEOS-II/AMSR/AMSR-L1A.003 Accept:application/x-bibtex

richardhallett commented 6 years ago

As content-negotiation is also directly supported in lupo, httpie calls to reproduce:

http https://app.datacite.org/10.5067/adeos-ii/amsr/amsr-l1a.003 Accept:application/x-bibtex

Returns 200 OK but there is no body content

In addition created exact same metadata used for this and put it in test environment, however this does not show the same problem

http https://app.test.datacite.org/10.70048/ywz5-6741 Accept:application/x-bibtex

mfenner commented 6 years ago

10.5067/ASTER/AST14DEM.003 generates bibtex (maybe because of a fix for frozen strings), the other three DOIs do not. Looks like an issue specific to the metadata rather than a generic issue.

mfenner commented 6 years ago

Bibtex is generated for all four DOIs using the bolognese command line tool.

richardhallett commented 6 years ago

The lupo code makes a call to citation.crosscite.org and uses the citeproc json format as the payload for converting to other formats. Using httpie you can do a similar call (citeproc.json is the metadata for 10.5067/ADEOS-II/AMSR/AMSR-L1A.003):

http -v POST https://citation.crosscite.org/format style==bibtex locale==en-US < citeproc.json

This however works, my current theory is it's related to the maremma library specifically as opposed to any specific formatting problems.

mfenner commented 6 years ago

Lupo is only calling citation.crosscite.org for formatted citations (when format.citation): https://github.com/datacite/lupo/blob/master/app/controllers/index_controller.rb#L12-L25

mfenner commented 6 years ago

This has been fixed in the Lupo content negotiation, but still doesn't work in our public content negotiation.

richardhallett commented 6 years ago

Original problem was fixed and further problem of the public data citation service has also been resolved. Solution: Updating maremma and bolognese in the main citation code base.

katrinleinweber commented 5 years ago

I'm having a similar problem with many, almost all audiovisual items from TIB of 2018: Cite > BibTeX remains empty. Tried other browsers, disabling JavaScript blockers, etc. Worth another issue, or re-opening this one?

daslerr commented 5 years ago

@katrinleinweber This appears to have been fixed in the course of other updates. Let us know if you're still having trouble.

katrinleinweber commented 5 years ago

Yes, fixed :-) Thank you!