Add missing sort parameter options for GET /dois - Githubissues

datacite / lupo

DataCite REST API

https://api.datacite.org

MIT License

12 stars 8 forks source link

Add missing sort parameter options for GET /dois #1098

Closed KellyStathis closed 6 months ago

KellyStathis commented 10 months ago

Purpose

Add missing "sort" parameter options for a GET request to /dois.

Approach

Add parameters listed here: https://github.com/datacite/lupo/blob/87a88371055cf8555a843c7becab4d2ac8db1934/app/controllers/datacite_dois_controller.rb#L16-L54

Open Questions and Pre-Merge TODOs

[ ] Should we update https://support.datacite.org/docs/api-queries#additional-parameters with the specific options available for sorting?

Learning

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.