DEPRECATION WARNING: ActiveModel::Errors#values is deprecated and will be removed in Rails 7.0.
To achieve the same use:
errors.map { |error| error.message } (called from block in serialize_errors at /home/app/webapp/app/controllers/concerns/error_serializable.rb:15)
.DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: users/welcome.text.erb (called from format_message_text at /home/app/webapp/app/models/concerns/mailable.rb:166)
DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: users/welcome.html.erb (called from format_message_html at /home/app/webapp/app/models/concerns/mailable.rb:188)
DEPRECATION WARNING: Calling << to an ActiveModel::Errors message array in order to add an error is deprecated. Please call ActiveModel::Errors#add instead. (called from block in validate_each at /home/app/webapp/app/validators/xml_schema_validator.rb:69)
Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.
Purpose
DEPRECATION WARNING: ActiveModel::Errors#values is deprecated and will be removed in Rails 7.0.
To achieve the same use:
errors.map { |error| error.message } (called from block in serialize_errors at /home/app/webapp/app/controllers/concerns/error_serializable.rb:15) .DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: users/welcome.text.erb (called from format_message_text at /home/app/webapp/app/models/concerns/mailable.rb:166) DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: users/welcome.html.erb (called from format_message_html at /home/app/webapp/app/models/concerns/mailable.rb:188)
DEPRECATION WARNING: Calling
<<to an ActiveModel::Errors message array in order to add an error is deprecated. Please callActiveModel::Errors#addinstead. (called from block in validate_each at /home/app/webapp/app/validators/xml_schema_validator.rb:69)closes: https://github.com/datacite/lupo/issues/1099
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: