Lupo is the central place that does this validation for Fabrica and MDS. The only implementation necessary was to add Schema 3, etc to the list of invalid schemas. Otherwise it works as required. The only task that is left to be done is to add tests to Lupo to verify that the requirements are met.
Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.
Purpose
Lupo is the central place that does this validation for Fabrica and MDS. The only implementation necessary was to add Schema 3, etc to the list of invalid schemas. Otherwise it works as required. The only task that is left to be done is to add tests to Lupo to verify that the requirements are met.
Spec Documents
closes: https://github.com/datacite/lupo/issues/1270
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: