search

datacite / omniauth-orcid

ORCID Strategy for OmniAuth
MIT License
9 stars 9 forks source link

api_base_url for production member api wrong? #14

Open nicolasfranck opened 6 years ago

nicolasfranck commented 6 years ago

api_base_url now only distinguishes between the public api and the public sandbox api. The member api is not used:

When requesting the person details it uses https://pub.orcid.org instead of https://api.orcid.org. Seems like method site and namespace are not used anymore?

nicolasfranck commented 6 years ago 
def api_base_url
    site + "/v#{API_VERSION}"
end

?

nicolasfranck commented 6 years ago

probably need to include the token when requesting the person details, otherwise you'll get "access denied" in the member api.

nicolasfranck commented 6 years ago

What do you mean by "discussion"? Where this behaviour should be implemented (either in your code, or in the callback code)?

mfenner commented 6 years ago

discussion is a label we use in our Kanban board at https://waffle.io/datacite/datacite. There is more than one way to resolve this.

nicolasfranck commented 6 years ago

See https://github.com/datacite/omniauth-orcid/pull/15

nicolasfranck commented 3 years ago

any news on this?