Open mfenner opened 4 years ago
@mfenner, I have addressed all the issues - please see below:
Item | Status | Comment |
---|---|---|
I would put the query into the readme | Done | Included an example query and the user story |
I would consider restructuring the query to be more explicit that we are looking at outputs for a particular funder | Done | |
use types { resourceType } to have a more specific description of the outputs | Done | See Type column in html table of outputs |
use dates { date dateType } to have more specific publication dates, enabling a bar graph that is by month and not by year | Done | See Number of Outputs per Year bar graph |
use formattedCitation(style: "vancouver") instead of bibtex to format the metadata into a human readable format. | Done | See the second html table. As suggested elsewhere, also included in this table Descriptions, and moved from table 1 to table 2 counts of citations, views, downloads. |
extracting the author information (many of them have ORCID IDs) and do something with it, e.g. a visualization linking them to the outputs.+ | Done | See the co-authorship chord plot at the bottom, as suggested elsewhere |
handle duplicates/versions, which is common with Zenodo. | Done | As suggested elsewhere, checking versionOfCount > 0 as the flag to exclude a given output (because it's a version of another resource) |
@datasome Looks good. The chord diagram came out really nice. Maybe a few small changes will improve it:
I think the bar chart outputs over time can be improved. I would include every month from project start December 2017 until project end November 2020, not just months with outputs.
@mfenner, I have done the following to address the above feedback:
Please note that I have not sorted creator names by FREYA partner affiliation as GraphQL query does not return affiliations currently. Will revise once creator affiliations can be retrieved.
@mfenner, I have now addressed the following comments from today's meeting:
@mfenner, I've added a fix to display the chord plot in mybinder.org - following the work-around suggested in https://github.com/shahinrostami/chord/issues/1. This actually writes out the plot's html to the server and then displays that html inside the notebook. The fix also works in JupyterLab.
@mfenner, I have now documented in Markdown the notebook for user story 10. Please note that the top Markdown table appears borderless in Jupyter lab and mybinder.org, but somehow not in github.
In this initial feedback I want to focus on the GraphQL used, and potential improvements.
use
types { resourceType }
to have a more specific description of the outputs, e.g.Presentation
orProject deliverable
.dates { date dateType }
to have more specific publication dates, enabling a bar graph that is by month and not by yearformattedCitation(style: "vancouver")
instead ofbibtex
to format the metadata into a human readable format. This assumes that the notebook generates a nicely formatted document rather than a bibtex file to download (we could do that in another notebook).