datacite / pidgraph-notebooks-python

MIT License
14 stars 9 forks source link

Updates to the Single DMP notebook #17

Closed briri closed 3 years ago

briri commented 3 years ago
review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

briri commented 3 years ago

@kjgarza I've addressed the issues you noted with the single-dmp notebook and also made some changes to the all-dmps notebook to update the funder and repo ids used based on the user's selection for Org.

The all-dmps doesn't provide us with any publication or dataset info. I'm guessing this is because its looking for the DMP DOI to be a relatedIdentifier on their records. Is that an accurate assumption?

I'm not sure why the funder query never returns anything for either the 'NSF' or 'Divison of Ocean Sciences' funder ids. If you select the CDL ror and run the notebook, you can see those funders listed in the org and repo tables but I cannot get the fuunder one to return anything.