search

datacite / pidgraph-notebooks-python

MIT License
14 stars 9 forks source link

User story #3 #7

Open FrancesMadden opened 4 years ago

FrancesMadden commented 4 years ago

A few comments on this user story from a documentation perspective.

Define and Run GraphQL query - I don't think it's specified that the query on University of Oxford is being run based on its ROR ID except that the hyperlink resolves to the ROR record.

I think the instructions on how to use the vega editor could have a few extra points to avoid losing people. Mentioning opening the .txt files in a new tab (binder doesn't default to this and then you have reload the binder page) and paste them in overwriting the default text on the left side of the editor. I was viewing the vega editor using a mac and it I had to use arrows to scroll up and down but I don’t think that's an issue.

I think the overlay text on the diagrams is excellent - really clear and illustrative.

datasome commented 4 years ago

@FrancesMadden - glad you liked the overlays and thanks for the comments - have just pushed a fix to address them. Please let me know of any further issues.