This change adds missing contributor information from the full XML example, including nameIdentifier, given/familyName, and affiliation, and removes trailing slashes from ORCID iDs.
There were also several discrepancies between the XML example and the test DOI. These discrepancies were resolved via updates to the test DOI 10.82433/B09Z-4K37, to minimize changes to the stored XML examples since these are used in testing.
Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.
Purpose
closes: https://github.com/datacite/datacite/issues/2063
Approach
This change adds missing contributor information from the full XML example, including nameIdentifier, given/familyName, and affiliation, and removes trailing slashes from ORCID iDs.
There were also several discrepancies between the XML example and the test DOI. These discrepancies were resolved via updates to the test DOI 10.82433/B09Z-4K37, to minimize changes to the stored XML examples since these are used in testing.
Once these changes are merged, the XML hosted on the schema website at https://schema.datacite.org/meta/kernel-4.5/example/datacite-example-full-v4.xml should match the XML and JSON for the test DOI 10.82433/B09Z-4K37.
Open Questions and Pre-Merge TODOs
Learning
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: