Schema 4.6 draft - Githubissues

datacite / schema

DataCite Metadata Schema Repository

https://schema.datacite.org

46 stars 16 forks source link

Schema 4.6 draft #144

Open ashwinisukale opened 1 month ago

ashwinisukale commented 1 month ago

Purpose

closes: https://github.com/datacite/schema/issues/141

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

codycooperross commented 1 month ago

How does this release play with the stylistic changes that Kelly is doing? Are they being released at the same time?

@KellyStathis I'm not sure I have the most context on this—can you provide some insight?

KellyStathis commented 1 month ago

How does this release play with the stylistic changes that Kelly is doing? Are they being released at the same time?

@KellyStathis I'm not sure I have the most context on this—can you provide some insight?

Sorry @codycooperross and @svogt0511 I missed this last week.

The redesign of the schema site is on track to launch at the end of October. Once that's complete, I would merge those changes into this schema-4.6-draft branch. It is mostly CSS changes, but some of the pages will have minor structural changes (e.g., changing a heading level) that we'll want to incorporate here. There may be a few merge conflicts.

ashwinisukale commented 1 month ago

I think one of the last pieces of this work, assuming that all the new values are tested as valid against the XSD, is to copy all of the spec/kernel-4.6 tests to the spec/kernel-4 folder. These two should be identical, to my memory, because the XSD is identical as well. @svogt0511 does that sound right?

I have created a ticket which will address this https://github.com/datacite/schema/issues/146 here I am also addressing correction of test cases in other versions.