datacite / volpino

The DataCite Profiles service
https://profiles.datacite.org
MIT License
2 stars 0 forks source link

Certain manual ORCID claims receive [{"status"=>404, "title"=>"Not found"}] errors #109

Open codycooperross opened 2 years ago

codycooperross commented 2 years ago

Describe the bug

When certain Profile accounts manually claim certain DOIs, the claims receive "Not found" errors and fail. Errors resemble the following:

[Error] 0000-0002-4684-9769 – 10.2312/egs.20221020: [{"status"=>404, "title"=>"Not found"}]

The claim will fail repeatedly if the DOI is claimed again. Other Profile accounts are able to claim the same DOI without issue.

Expected Behaviour

Claims should be processed or receive a descriptive error.

Steps to Reproduce

The error is difficult to reproduce but can be reproduced with certain Profile accounts and DOIs; for example, 0000-0002-4684-9769 with https://commons.datacite.org/doi.org/10.5438/sjx9-hb16.

Context (Environment)

The error makes it impossible to claim certain DOIs in Commons as a user.

Proposal

Hypothesis

The error is likely being generated here:

https://github.com/datacite/volpino/blob/1883d6f541ad9924ad3517756f01c82b832a3ed5/app/models/claim.rb#L197

After attempting to update the work here with a put code that is no longer consistent with the ORCID record:

https://github.com/datacite/volpino/blob/1883d6f541ad9924ad3517756f01c82b832a3ed5/app/models/claim.rb#L268

Front logo Front conversations

kjgarza commented 2 years ago

i was able to claim without a problem. It seems more related to the ORCID account image

codycooperross commented 2 years ago

Maybe, but I think the issue has more to do with the Profile account and the claim itself. Users with this issue can claim other DOIs without a problem. The issue does not appear to involve the DOI since, as you point out, other users are able to claim the DOI. The error persists after replacing the ORCID token.

jlwasserman commented 2 years ago

I believe I am having the same issue. I went to this URL: https://commons.datacite.org/doi.org/10.17610/t6m89t and tried to click the button to add the item to my ORCID record. However, it says "Claim waiting" for a bit, then returns to saying "Claim DOI" and under that, says "Error Not found." It does not add the article to my ORCID record.

The first time I tried this, it did add it to my ORCID record, but when I was editing the information on ORCID, the record somehow disappeared. I have tried the steps above to re-add the article, to no avail.

I have tried logging out of ORCID and DataCite and back in again, deleting my ORCID token and restoring it, revoking DataCite access to ORCID and then restoring it, and clearing cookies, but none of those steps worked.

codycooperross commented 2 years ago

@jlwasserman Thank you for providing this additional context! This will help us narrow down the issue.

jlwasserman commented 2 years ago

I was able to recreate the error using a new publication of mine: https://commons.datacite.org/doi.org/10.17610/t66w31. The issue appears to be this:

I was able to successfully claim it on DataCite, and it then appeared on my ORCID. But when I deleted it from my ORCID record (which I think I must have accidentally done the first time) on ORCID, then I can no longer re-claim it on DataCite. I get the same error described above ("It says 'Claim waiting' for a bit, then returns to saying 'Claim DOI' and under that, says 'Error Not found.'). So I think the error has something to do with citations being deleted from ORCID and then trying to reclaim them through DataCite.

codycooperross commented 2 years ago

@jlwasserman Thank you again for the context. I've been able to investigate the issue further and suspect the bug stems from inconsistencies between our database information and the ORCID record, such as in the example you describe. I've updated my hypothesis, and we will continue to work toward a solution.

jlwasserman commented 2 years ago

Hello. I was wondering if you have any updates on this issue? Thanks.

codycooperross commented 2 years ago

While the underlying issue is not yet resolved, we should be able to provide a workaround by removing problematic put codes in our Claims database. Please contact support@datacite.org if you encounter this issue.