Upcases orcids when creating orcid_client Work and Notification objects in the Claim model. The orcid attribute is used to construct ORCID API request URLs, which may require uppercase characters for ORCID's pattern matching. Because orcids are currently encoded with lowercase characters, this may be causing the 404 errors some users are seeing.
Learning
Looking at ORCID's old nginx code, the pattern match for the API reverse proxy has always been uppercase X. Lower has probably never worked.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.
Purpose
closes: #115
Approach
Upcases
orcids when creatingorcid_clientWork and Notification objects in the Claim model. Theorcidattribute is used to construct ORCID API request URLs, which may require uppercase characters for ORCID's pattern matching. Becauseorcids are currently encoded with lowercase characters, this may be causing the 404 errors some users are seeing.Learning
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: