This PR fixes the broken tests in the rspec suite. Most of the changes are simple fixes in places where the tests had not kept up with changes to the code (e.g structure of responses changing).
Also added is a workflow to run the test suite on pull requests.
closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
[x] Re-enable tests in deploy workflow
[x] Re-enable tests in release workflow
Learning
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.
Purpose
This PR fixes the broken tests in the rspec suite. Most of the changes are simple fixes in places where the tests had not kept up with changes to the code (e.g structure of responses changing).
Also added is a workflow to run the test suite on pull requests.
closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: