Removes the the option in settings form to set the User `is_public` attribute - Githubissues

datacite / volpino

The DataCite Profiles service

https://profiles.datacite.org

MIT License

2 stars 0 forks source link

Removes the the option in settings form to set the User `is_public` attribute #142

Closed codycooperross closed 1 year ago

codycooperross commented 1 year ago

Purpose

Currently, the User is_public attribute is not used in DataCite systems. This PR removes the option to set the attribute in user settings.

Approach

Removes the ability to set and view the is_public attribute in the Profiles user form.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.