search

datacleaner / DataCleaner

The premier open source Data Quality solution
GNU Lesser General Public License v3.0
595 stars 180 forks source link

Feature #1767 - RegexSwap client reimplementation based on JSON endpoint #1896

Closed kaspersorensen closed 2 years ago

kaspersorensen commented 2 years ago

As described and discussed in #1767 - this changes the RegexSwapClient class to use https://datacleaner.github.io/content/regexes.json for fetching regexes instead of the decomissioned old XML endpoints.

LosD commented 2 years ago

Code itself looks mostly good to me, but I see some changes from spaces to tabs in RegexSwapClient.java and Regex.java. If I remember correctly, the code style is spaces.

kaspersorensen commented 2 years ago

Code itself looks mostly good to me, but I see some changes from spaces to tabs in RegexSwapClient.java and Regex.java. If I remember correctly, the code style is spaces.

OMG yes. This is what happens when you (I) don't code for a long time and go rogue with a fresh Eclipse installation :D Thanks for the feedback notes!