search

datacleaner / DataCleaner

The premier open source Data Quality solution
GNU Lesser General Public License v3.0
595 stars 180 forks source link

Value distribition without scala #1898

Closed kaspersorensen closed 2 years ago

kaspersorensen commented 2 years ago

This solves a small part of #1890 by rewriting some Scala-based rendering components in the Value Distribution module.

I did not convert the unit tests. They are incredibly reliant on Scala's string handling. And they're also kinda crazy tests that compare very long strings. I think they should simply be removed when we decomission Scala. But I kept them around to show that my change works well.

Note that I modified the tests a bit because the new output has different indentation than the old. I consider this to be a non-issue.

LosD commented 2 years ago

LGTM (no proper testing from my side yet, though)