search

datacleaner / DataCleaner

The premier open source Data Quality solution
GNU Lesser General Public License v3.0
589 stars 180 forks source link

KeyListener not fired when graph has no focus. #312

Open tomaszguzialek opened 9 years ago

tomaszguzialek commented 9 years ago

I encountered the issue while testing #307.

To reproduce: 1) Add a table (or two or more) to an empty graph 2) Highlight them by drawing a rectangle around the component(s). Important: Click and draw immediately (only one click). 3) Hit delete button 4) Nothing happens, the key listener is not fired at all.

Now substitute step 2 with: Click on the empty space on the graph. After the click, highlight them by drawing a rectangle around. Now there are two clicks: first on the empty space, second for drawing. By doing this the graph gets focus and the key listener is fired.

kaspersorensen commented 9 years ago

An idea: We could consider not adding the key listener to the job graph's "visualizationViewer" component, but rather to the surrounding scrollpane or the DCPanel that contains the whole shabang. That might give us more certainty to get notified about the key event.

kaspersorensen commented 9 years ago

Seems this is not achievable within the 4.0 timelines, so it'll become a 'known bug' of the release. Removing the milestone.