Updated opencsv dependency, fixed depending code.

datacleaner / metamodel

DataCleaner fork of Apache Metamodel

Apache License 2.0

0 stars 1 forks source link

Updated opencsv dependency, fixed depending code. #2

Closed bascan closed 2 years ago

bascan commented 2 years ago

Motivation I'm working on a product that depends on the original Apache metamodel as well as opencsv. We'd like to update our opencsv dependency to the latest version without breaking metamodel. Furthermore, we'd like to replace our metamodel dependency with a release artefact from the datacleaner fork soon.

Contents

The opencsv version has been bumped in the root POM
New checked CsvValidationException is caught
CSVReader is constructed through the new CSVReaderBuilder

Greetings from netgo Software Berlin!

kaspersorensen commented 2 years ago

Hi @bascan Thank you for you PR. And sorry for the late response - since this is still a new repo I had not yet configured my email notifications properly! But I see your PR now and if it passes the tests etc. I think it looks good. Thanks a lot!

kaspersorensen commented 2 years ago

Hi @bascan It seems you also need to make a few updates in the arff module (which depends on the csv module). Can you make those?

bascan commented 2 years ago

Hi @kaspersorensen Thanks for your comment. Yes, we'll take care of that. Another netgo dev is currently on it and he will push the required updates to this PR soon.

peichhorn-netgo commented 2 years ago

Hi @kaspersorensen The arff module was updated accordingly. If you have any other comments or suggestions please let me know.

kaspersorensen commented 2 years ago

Thank you for the contribution! It is merged 🍾

kaspersorensen commented 2 years ago

Hey there, just a heads up that we've released this with version 5.3.5!

peichhorn-netgo commented 2 years ago

That's great news. Thank you for your efforts!