search

datacleaner / pdi-datacleaner

Data Profiling for Pentaho Data Integration (PDI) with DataCleaner
GNU Lesser General Public License v3.0
7 stars 4 forks source link

NPE when running plugin via Kitchen environment #35

Closed kaspersorensen closed 8 years ago

kaspersorensen commented 8 years ago

See forum: https://datacleaner.org/topic/1122/Help-with-Pentho-Kitchen-running-job-file-with-Execute-DataCleaner-job

Even includes a suggestion for a fix :)

nashhoogwater commented 8 years ago

I ran into the same problem and I needed it fixed, because the plugin doesn't work if you use kitchen. It is based on the comment left on the forum. A diff is included as attachment.

fix-kitchen.zip

kaspersorensen commented 8 years ago

Thank you very much @nashhoogwater ! I think it's very cool to see some contributions here. Maybe @ClaudiaPHI or @LosD can put it on their radar to check the patch sometime soon, since I'm no longer part of the core DC dev team)

LosD commented 8 years ago

It's added to the current sprint, so it should go be added for inclusion within the next two weeks.

Thanks @nashhoogwater! :)

nashhoogwater commented 8 years ago

Added a small additional fix to the same patch for a different issue al together. It is possible to add additional arguments to the DataCleaner execution. However if you use variables they are not substituted. I added a fix for this.

fix-additional-argument-and-kitchen.zip

dobeslao commented 8 years ago

I came here only to say thank folks, great job.