datacloning / dclone

Data Cloning and MCMC Tools for Maximum Likelihood Methods
https://github.com/datacloning/dclone
7 stars 2 forks source link

Redesign model file read/write #9

Closed psolymos closed 6 years ago

psolymos commented 6 years ago

After submitting a CRUN update, apart from minor stuff, I got:

Please ensure that your functions (e.g. write.jags.model(filename = "model.txt", dir = getwd(),...)) do not write by default or in your examples in the user's home filespace. That is not allow by CRAN policies. Please only write/save files if the user has specified a directory. In your examples you can write to tempdir().

This will require carefully testing almost all functions. If tempfile is used with tempdir included (default), it also means that the file name needs to be passed with full path to the cleanup functions. This could potentially complicate parallel execution, unless each job creates its own temp file (which might be more robust than the current approach).

Needs to be tested as a separate branch.

psolymos commented 6 years ago

Been addressed in v2.2