search

datacommonsorg / data

Apache License 2.0
57 stars 105 forks source link

PowerPlant.isPartOf should be object prop (PublicUtility) not string #878

Open VladimirAlexiev opened 10 months ago

VladimirAlexiev commented 10 months ago

This PowerPlant https://www.datacommons.org/browser/eia/pp/2322 has link isPartOf being string "eia/u/13407", rather than a thing: the corresponding PublicUtility https://www.datacommons.org/browser/eia/u/13407 . Consequently, the section "In Arcs" of the utility doesn't show its power plants.

Maybe the bug is at https://github.com/datacommonsorg/data/blob/master/scripts/us_eia/eia_860/2_plant.tmcf#L12 . It calls a function isPartOf: C:EIA_860_Schedule_2->UtilityDcid but it seems to me the output is formatted like a string (just like the prev line eiaPlantCode: C:EIA_860_Schedule_2->PlantCode) ?

VladimirAlexiev commented 10 months ago

Note: https://datacommons.rff.org uses worse IDs (GUIDs instead of EIA ids), but doesn't have this problem: https://datacommons.rff.org/browser/dc/05gsw4m93mz6 (utility) links to https://datacommons.rff.org/browser/dc/3lwrcytjq2k09 (power plant).