search

datacommonsorg / mixer

Mixer provides the translator engine and API interface to access Data Commons graph
https://datacommons.org
Apache License 2.0
13 stars 35 forks source link

Add is_dc_aggregate to facet id #1420

Closed n-h-diaz closed 1 week ago

n-h-diaz commented 1 week ago

This is so online Mixer aggregations can be tagged with "is_dc_aggregate" so that the output facet will be different than the input facets / the response indicates that this has been aggregated by us

This will modify all the existing facet ids, so the goldens need to be updated too

n-h-diaz commented 1 week ago

Thanks Natalie!

Can you add more context in the PR description for future reference?

Also, since this will change all observation responses, we should try to get this to staging sooner than usual and monitor it closely around prod rollout.

Thanks for the review!

Added more to the description and sounds good to test early