datacommonsorg / website

Code for the Data Commons website
https://datacommons.org
Apache License 2.0
20 stars 73 forks source link

[rag eval] add rag ans section #4380

Closed chejennifer closed 1 week ago

chejennifer commented 1 week ago

https://github.com/datacommonsorg/website/assets/69875368/7334d32d-4042-41a8-aca0-c7a8ef75e62f

pradh commented 1 week ago

Awesome!

usability nit: on the claim-count UI, should we make the "-" and "+" bigger? That's the one we'll be clicking more. Also should we put "+" on the LHS, so its more natural to click it (I imagine we more often hit +)?

chejennifer commented 1 week ago

Awesome!

usability nit: on the claim-count UI, should we make the "-" and "+" bigger? That's the one we'll be clicking more. Also should we put "+" on the LHS, so its more natural to click it (I imagine we more often hit +)?

made the buttons bigger, but putting + on LHS feels unintuitive .. can change if we feel like that's useful though https://screenshot.googleplex.com/6CpphnDKkXgtyEa

pradh commented 1 week ago

Awesome! usability nit: on the claim-count UI, should we make the "-" and "+" bigger? That's the one we'll be clicking more. Also should we put "+" on the LHS, so its more natural to click it (I imagine we more often hit +)?

made the buttons bigger, but putting + on LHS feels unintuitive .. can change if we feel like that's useful though https://screenshot.googleplex.com/6CpphnDKkXgtyEa

ok. but curious about the reason it feels unintuitive?

my rationale was, given english is L->R lang, the first thing to do comes to the L. And starting from 0, the first thing to do is +, not - :)

pradh commented 1 week ago

Awesome! usability nit: on the claim-count UI, should we make the "-" and "+" bigger? That's the one we'll be clicking more. Also should we put "+" on the LHS, so its more natural to click it (I imagine we more often hit +)?

made the buttons bigger, but putting + on LHS feels unintuitive .. can change if we feel like that's useful though https://screenshot.googleplex.com/6CpphnDKkXgtyEa

ok. but curious about the reason it feels unintuitive?

my rationale was, given english is L->R lang, the first thing to do comes to the L. And starting from 0, the first thing to do is +, not - :)

But leaving it as is, is fine for now.

chejennifer commented 1 week ago

Awesome! usability nit: on the claim-count UI, should we make the "-" and "+" bigger? That's the one we'll be clicking more. Also should we put "+" on the LHS, so its more natural to click it (I imagine we more often hit +)?

made the buttons bigger, but putting + on LHS feels unintuitive .. can change if we feel like that's useful though https://screenshot.googleplex.com/6CpphnDKkXgtyEa

ok. but curious about the reason it feels unintuitive?

my rationale was, given english is L->R lang, the first thing to do comes to the L. And starting from 0, the first thing to do is +, not - :)

I think it feels unintuitive because on a number line, numbers decrease going to the left and increase going to the right. So I associate left with decreasing and right with increasing .. but that might just be me