search

datacommonsorg / website

Code for the Data Commons website
https://datacommons.org
Apache License 2.0
24 stars 88 forks source link

[timeline] fix ratio bug #4493

Closed chejennifer closed 4 months ago

chejennifer commented 4 months ago

there was a bug in picking the denominator observation where when comparing if next denom is better, it was comparing with the earliest denominator & not the previous denominator. This caused weird behavior for per capita timelines

autopush: https://screenshot.googleplex.com/6gh9Nyjr7kg638C local: https://screenshot.googleplex.com/BHUsQPMih5X27Hy

pradh commented 4 months ago

Nice find! Does the timeline in the local screenshot still go above 100%?

chejennifer commented 4 months ago

Nice find! Does the timeline in the local screenshot still go above 100%?

Nope, does not go above 100%!