datacontract / datacontract-cli

CLI to manage your datacontract.yaml files
https://cli.datacontract.com
Other
437 stars 85 forks source link

Issues/193 fix all todos in html export #203

Closed jpraetorius closed 4 months ago

jpraetorius commented 4 months ago

This not only addresses the Examples mentioned in #193 but additionaly

jpraetorius commented 4 months ago

This is how things look like

SCR-20240515-pbks

simonharrer commented 4 months ago

jinja partials would be awesome

simonharrer commented 4 months ago

layout of the flags definition seems broken

jpraetorius commented 4 months ago

layout of the flags definition seems broken

That was a simple showcase to test out how enum would render. It doesn't have any other properties defined that would go in the third column. This is how it would be with some more content (but we can also try to move the enums to a different place) SCR-20240516-idpx

jochenchrist commented 4 months ago

I'd put them into the description column, as the enum list could become quite long. To reduce abstraction, maybe I'd call them "Enum" instead of "Allowed values"?

jpraetorius commented 4 months ago

We can do that, I just don't really like how that last column then is the funny grab bag of all kinds of individual divs stacked on top of each other that may or may not be there – there's no real structure to it for the reader to grasp

jpraetorius commented 4 months ago

So, here we go:

SCR-20240516-jyse

jochenchrist commented 4 months ago

The partials are a bit dangerous, as you need to remember to add them (as data files) to the MANIFEST.in

jochenchrist commented 4 months ago

The partials are a bit dangerous, as you need to remember to add them (as data files) to the MANIFEST.in

Added them to the MANIFEST. in file

jochenchrist commented 4 months ago

Thanks for your contribution. Happy to merge :)