search

datacontract / datacontract-cli

CLI to manage your datacontract.yaml files
https://cli.datacontract.com
Other
352 stars 60 forks source link

feat: add array and struct field management in glue importer #271

Closed pierre-monnet closed 1 week ago

pierre-monnet commented 1 week ago

For now when Glue table contains array or struct field, it is returned as "variant" and items or subfields aren't retrieve.

jochenchrist commented 1 week ago

Great contribution. LGTM.

jochenchrist commented 1 week ago

Please check the test results

pierre-monnet commented 1 week ago

Please check the test results

oops I made some typos in my test case and expected result, I fixed them

jochenchrist commented 1 week ago

Merged, again, thanks for your contribution.

Do you need are quick release for this feature?

pierre-monnet commented 1 week ago

Do you need are quick release for this feature?

Thanks a lot ! There is no emergency, it can be include in the next release. Keep me in touch :)

simonharrer commented 1 week ago

@pierre-monnet can you provide a CHANGELOG entry, please? Perhaps in another PR?

pierre-monnet commented 1 week ago

@pierre-monnet can you provide a CHANGELOG entry, please? Perhaps in another PR?

No problem, I'll work on it