datacontract / datacontract-specification

The Data Contract Specification Repository
https://datacontract.com/
MIT License
278 stars 41 forks source link

Add additional configuration for addressing Redshift servers #96

Closed jon-ruckwood closed 1 month ago

jon-ruckwood commented 1 month ago

You cannot properly define a Redshift output port using the current specification. For example:

example:
  type: redshift
  account: '123456789012' 
  database: analytics
  schema: analytics

The fragment only identifies the account the cluster is in, it doesn't provide the cluster’s identity.

My change adds the additional properties clusterIdentifier, host, port and endpoint to allow for more options when addressing Redshift output ports.

For example, using the host property:

analytics:
  type: redshift
  account: '123456789012' 
  database: analytics
  schema: analytics
  host: analytics-cluster.example.eu-west-1.redshift.amazonaws.com
  port: 5439

I've also updated the README to add documentation, provide examples and corrected property descriptions.

jon-ruckwood commented 1 month ago

@jochenchrist @simonharrer 👋 Hi, could you please take a look at this PR, when you get some time? I’d really appreciate feedback. Accurately addressing Redshift would be a great help to us.