search

datacraft-dsc / starfish-java

Developer Toolkit for the Data Ecosystem
3 stars 2 forks source link

hardcoding need to be removed from main class #108

Open AyushVerma2 opened 4 years ago

AyushVerma2 commented 4 years ago

DirectPurchase code has: static { _addresses = new HashMap<String, String>(); _addresses.put("8996", "0xc0C528855f27aA3FbfE35CedE49AC37f3f881934"); }

ilyabukalov commented 4 years ago

This is autogenerated code. So any modification will be reverted back in case of new changes/re-generation. And this line exactly is never used in runtime. The address is set dynamically from config.

ilyabukalov commented 4 years ago

The correct solution is to exclude this file from git while including whole command line steps of truffle+solc generation+compilation to maven which looks complicated and being postponed

AyushVerma2 commented 4 years ago

Need to be discussed with Ilya.