search

datacraft-sciences / confuse

Eclipse Public License 1.0
32 stars 3 forks source link

added multiclass-mcc #10

Closed behrica closed 2 years ago

shark8me commented 2 years ago

Thanks for the PR! A descriptive fn name would be nice to have, other than that, looks good to me

behrica commented 2 years ago

I did not change the names, but made the functions local. They make indeed only sense in the context of MCC and by looking at the formula in wikipedia.

Not sure, if I should still change the names.

behrica commented 2 years ago

I did an other commit, replacing the names by something "longer". Not sure, if better, as it makes the "formula" harder to read.

Maybe decide yourself, which you prefer.

behrica commented 2 years ago

There was an edge case where we get a division by 0. In this case teh MCC is consiered 0.

sklearn does the same.

shark8me commented 2 years ago

Looks good to me, thanks for the PR!