search

datactive / bigbang

Scientific analysis of collaborative communities
http://datactive.github.io/bigbang/
MIT License
154 stars 51 forks source link

Formatting all files #408

Closed Christovis closed 3 years ago

Christovis commented 3 years ago

The PR that suggested the pre-commit routine was merged before all files could be reformatted according to flake8, isort, and black. Therefore I open this PR that will finish formatting all other files too. Once this PR is merged into master, we can start to focus on the important bits :smiley_cat:

Christovis commented 3 years ago

The only weird thing that I encountered in the code is this line in archive.py flake8 pointed out that the variable future_comparison is never used, so I just removed it. But that leaves me asking whether the for loop is necessary...

sbenthall commented 3 years ago

Great work. Thanks for this @Christovis

As part of this merge I'm adding a change to the repo_loader regex that fixes a failing test on my local instance.

I'm not sure why those test failures are cropping up -- a bit mysterious.

Christovis commented 3 years ago

Btw. thanks for having resolved the regex issue in the repo_loader.py! I missed it :grimacing: