Add 3GPP mailing list URLs to /example/url_collections/

datactive / bigbang

Scientific analysis of collaborative communities

http://datactive.github.io/bigbang/

MIT License

149 stars 52 forks source link

Add 3GPP mailing list URLs to /example/url_collections/ #448

Closed Christovis closed 3 years ago

Christovis commented 3 years ago

This PR will add:

add examples/url_collections/listserv.3GPP.txt that lists all public mailing lists of 3GPP
add the argument only_mlist_urls: bool to ListservArchive.from_url() that assists in creating examples/url_collections/listserv.3GPP.txt
formatting changes according to black, isort, and flake8. The pre-commit routine only works if every developer has the .git/hooks/pre-commit which can be created by running $ pre-commit install in the terminal. We can set up a workflow for it later to take some burden from contributes later.

npdoty commented 3 years ago

This is tricky to review when it seems like the substantive change is just in 2 files. If you just want to add the data file listserv.3GPP.txt, that's easy to review and merge in a PR that makes just that change to the master branch.

For formatting issues, if that is still causing issues for every subsequent PR for people using the recommended pre-commit hooks, then I suggest we prioritize a PR that fixes any existing formatting issues and documents in the README the changes necessary to install and enforce the pre-commit hooks. (I wasn't aware of pre-commit install, so I may have been keeping this issue around.)

Christovis commented 3 years ago

Following @npdoty recommendation, this PR is aborted in order to divide it into two separate ones: 1) for listserv.3GPP.txt and add its method of creation within listserv.py 2) add workflow to automate pre-commit routine