search

datactive / bigbang

Scientific analysis of collaborative communities
http://datactive.github.io/bigbang/
MIT License
149 stars 52 forks source link

improve code coverage of mailman #471

Closed Christovis closed 3 years ago

Christovis commented 3 years ago

This PR is solving issue #343 and with that improving the code coverage of mailman.py For it I separated the mailman tests from the other tests in tests/unit/test_bigbang.py. Furthermore did I add new test data to tests/data/3GPP_mbox.

codecov-commenter commented 3 years ago

Codecov Report

Merging #471 (9703a5c) into main (d0cbc34) will increase coverage by 2.32%. The diff coverage is 97.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   71.91%   74.24%   +2.32%     
==========================================
  Files          15       16       +1     
  Lines        2183     2229      +46     
==========================================
+ Hits         1570     1655      +85     
+ Misses        613      574      -39
Flag Coverage Δ
unittests 74.24% <97.27%> (+2.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/unit/test_bigbang.py 97.88% <ø> (+0.33%) :arrow_up:
tests/unit/test_mailman.py 97.16% <97.16%> (ø)
bigbang/mailman.py 62.63% <100.00%> (+14.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0cbc34...9703a5c. Read the comment docs.