search

datactive / bigbang

Scientific analysis of collaborative communities
http://datactive.github.io/bigbang/
MIT License
149 stars 52 forks source link

Functions for 3GPP figures #480

Closed Christovis closed 3 years ago

Christovis commented 3 years ago

This PR contians:

codecov-commenter commented 3 years ago

Codecov Report

Merging #480 (e66a930) into main (23025d6) will increase coverage by 1.36%. The diff coverage is 91.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   75.07%   76.44%   +1.36%     
==========================================
  Files          16       19       +3     
  Lines        2323     2564     +241     
==========================================
+ Hits         1744     1960     +216     
- Misses        579      604      +25
Flag Coverage Δ
unittests 76.44% <91.22%> (+1.36%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bigbang/analysis/listserv.py 82.70% <82.70%> (ø)
bigbang/listserv.py 82.09% <96.36%> (+0.47%) :arrow_up:
bigbang/__init__.py 100.00% <100.00%> (ø)
tests/analysis/test_listserv.py 100.00% <100.00%> (ø)
tests/unit/test_listserv.py 100.00% <100.00%> (ø)
tests/unit/test_mailman.py 97.16% <100.00%> (ø)
tests/webscraping/test_listserv.py 90.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23025d6...e66a930. Read the comment docs.

sbenthall commented 3 years ago

Can we put analysis/listserv.py into bigbang/analysis/listserv.py

I think that keeps the source code all in one directory (bigbang) while using the directory structure to give the listserv analysis code a unique Python import path.