datactive / bigbang

Scientific analysis of collaborative communities
http://datactive.github.io/bigbang/
MIT License
152 stars 52 forks source link

Just a little cleanup of old files #579

Closed MridulS closed 1 year ago

MridulS commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Base: 73.37% // Head: 73.37% // No change to project coverage :thumbsup:

Coverage data is based on head (1c5787d) compared to base (3bbb735). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #579 +/- ## ======================================= Coverage 73.37% 73.37% ======================================= Files 30 30 Lines 3635 3635 ======================================= Hits 2667 2667 Misses 968 968 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `73.37% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/datactive/bigbang/pull/579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive) | Coverage Δ | | |---|---|---| | [bigbang/bigbang\_io.py](https://codecov.io/gh/datactive/bigbang/pull/579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive#diff-YmlnYmFuZy9iaWdiYW5nX2lvLnB5) | `79.72% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MridulS commented 1 year ago

Well the minor cleanup went on to become major one:

In this PR I have removed env.yaml/conda-setup/requirements.txt, I also have a feedstock request https://github.com/MridulS/staged-recipes/tree/bigbangpy_on_conda_forge which will let users do conda install bigbang-py but this would first require a fixed pypi distribution.

MridulS commented 1 year ago

In https://github.com/datactive/bigbang/pull/579/commits/46693a209cf4c0f2b3b93eb7cf6317ac75d77848 I have run black on all the files with the latest release of black + black default config to make the lint checks on github actions happy. This has added a lot more changes to this PR, I can use a different PR to put the black changes so it can be a bit more cleaner while reviewing this PR.

sbenthall commented 1 year ago

Thank you for all this great work!

I agree that removing setup.py and updating the docs is best.

Does this PR interact with #578 ?

MridulS commented 1 year ago

Does this PR interact with https://github.com/datactive/bigbang/issues/578 ?

Yes, I will try to fix both https://github.com/datactive/bigbang/issues/578 and #577 in this PR so we have clean pypi/conda install.

sbenthall commented 1 year ago

Hoorah!

MridulS commented 1 year ago

Ahhh, should have marked it WIP. I haven't checked everything. I will continue in a new PR

sbenthall commented 1 year ago

My apologies....