Closed MridulS closed 1 year ago
Base: 73.37% // Head: 73.37% // No change to project coverage :thumbsup:
Coverage data is based on head (
1c5787d
) compared to base (3bbb735
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Well the minor cleanup went on to become major one:
In this PR I have removed env.yaml/conda-setup/requirements.txt, I also have a feedstock request https://github.com/MridulS/staged-recipes/tree/bigbangpy_on_conda_forge which will let users do conda install bigbang-py
but this would first require a fixed pypi distribution.
In https://github.com/datactive/bigbang/pull/579/commits/46693a209cf4c0f2b3b93eb7cf6317ac75d77848 I have run black on all the files with the latest release of black + black default config to make the lint checks on github actions happy. This has added a lot more changes to this PR, I can use a different PR to put the black changes so it can be a bit more cleaner while reviewing this PR.
Thank you for all this great work!
I agree that removing setup.py and updating the docs is best.
Does this PR interact with #578 ?
Does this PR interact with https://github.com/datactive/bigbang/issues/578 ?
Yes, I will try to fix both https://github.com/datactive/bigbang/issues/578 and #577 in this PR so we have clean pypi/conda install.
Hoorah!
Ahhh, should have marked it WIP. I haven't checked everything. I will continue in a new PR
My apologies....
pre-commit install
after cloning bigbang and this could be documented. (Less the code the better :) )