datactive / bigbang

Scientific analysis of collaborative communities
http://datactive.github.io/bigbang/
MIT License
148 stars 52 forks source link

Use requests instead of urllib in mailman #584

Closed micahflee closed 1 year ago

micahflee commented 1 year ago

Fixes #581.

This changes the urllib code to use requests instead. Requests handles certificates better, so it successfully verifies SSL certificates.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.36 :tada:

Comparison is base (41327f1) 73.37% compared to head (8984634) 73.73%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #584 +/- ## ========================================== + Coverage 73.37% 73.73% +0.36% ========================================== Files 30 30 Lines 3635 3632 -3 ========================================== + Hits 2667 2678 +11 + Misses 968 954 -14 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `73.73% <33.33%> (+0.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/datactive/bigbang/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive) | Coverage Δ | | |---|---|---| | [bigbang/ingress/mailman.py](https://codecov.io/gh/datactive/bigbang/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive#diff-YmlnYmFuZy9pbmdyZXNzL21haWxtYW4ucHk=) | `67.82% <33.33%> (+6.35%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datactive)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.