Closed effyli closed 1 year ago
Tests are failing because dependencies have not been updated, it seems.
There may also be a merge conflict with recent changes to main
.
Patch and project coverage have no change.
Comparison is base (
7ee437e
) 73.20% compared to head (ab50a03
) 73.20%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@effli Thanks for this PR! Sorry for the very slow review turnaround.
This will be a great addition to BigBang. The only issue I'm getting is an error in cell 14.
You are using the append()
method of a Pandas DataFrame. But this is a deprecated feature that has been removed in the most recent version:
https://stackoverflow.com/questions/75956209/dataframe-object-has-no-attribute-append
Could you please update the Pandas version you have installed and correct this code? Otherwise, this PR is good to merge.
Hi Seb,
Thanks for checking my PR! I have fixed the problem and re-pushed the code.
Best, Effy
Best, Effy
On Fri, 5 May 2023 at 20:29, Sebastian Benthall @.***> wrote:
@effli Thanks for this PR! Sorry for the very slow review turnaround.
This will be a great addition to BigBang. The only issue I'm getting is an error in cell 14. You are using the append() method of a Pandas DataFrame. But this is a deprecated feature that has been removed in the most recent version:
https://stackoverflow.com/questions/75956209/dataframe-object-has-no-attribute-append
Could you please update the Pandas version you have installed and correct this code? Otherwise, this PR is good to merge.
— Reply to this email directly, view it on GitHub https://github.com/datactive/bigbang/pull/586#issuecomment-1536623353, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCDL6JPJ44AALLQAUUMJBLXEVBI7ANCNFSM6AAAAAAWHZF47Y . You are receiving this because you authored the thread.Message ID: @.***>
Thanks @effyli great work!
A few things to note: