search

datactive / bigbang

Scientific analysis of collaborative communities
http://datactive.github.io/bigbang/
MIT License
148 stars 52 forks source link

Failure in test_w3c.py : can't get message content #601

Closed sbenthall closed 11 months ago

sbenthall commented 12 months ago

The W3C error found in #600 was also, it seems, caught by the automated tests on this documentation update commit: https://github.com/datactive/bigbang/commit/075526f9648aa9f00e346ddf184a9f64d03c431d

So these really are quite recent UI changes.

Several errors were fixed by: https://github.com/datactive/bigbang/commit/6a0ec35731990af0d7d84cf845a2db339def9cd7

But one remains.

    def test__message_content(self, msg):
        lines = msg.get_payload()  # .split("C")[1].split("=")[0]
>       assert "I have been working on an update" in lines.split("\n")[0]
E       AssertionError: assert 'I have been working on an update' in ''

tests/ingress/test_w3c.py:38: AssertionError

Which corresponds to the missing body problem noted here: https://github.com/datactive/bigbang/issues/600#issuecomment-1646120088

sbenthall commented 11 months ago

Indeed, there were some other W3C web archive design changes that were breaking the W3CMessageParser. I've fixed the parse and tests are passing locally now.