search

datacute / Tiny4kOLED

Library for an ATTiny85 to use an SSD1306 powered, double buffered, 128x32 pixel OLED, over I2C
MIT License
264 stars 39 forks source link

`fill` and `filltoEOL` don't account for vertical memory addressing mode #18

Closed rsheldiii closed 5 years ago

rsheldiii commented 5 years ago

Hi there! thanks for making this library. I found a small issue with fill and probably a few other functions. In vertical addressing mode, according to the datasheet, when a segment is written the page address is incremented as opposed to the column address, opposite of horizontal and page addressing mode. In vertical addressing mode, the end of a line is 8 segments instead of 128, or 4 in our case due to double buffering.

What's interesting is despite commands 00-1F and B0-B7 being described as "for page addressing mode", setCursor seems to work just fine, though I am only using setCursor with an x value so far

datacute commented 5 years ago

duplicate of issue #19 (looks like you submitted the issue before completing it)