search

dataddo / pgq

Go queue implementation using postgres.
https://dataddo.com
Apache License 2.0
99 stars 6 forks source link

Make the MaxConsumeCount param configurable #4

Closed kedlas closed 11 months ago

prochac commented 11 months ago

Let's use uint, negative values are useless here. Also the merge should be synchronised with our update, as we rely on the former default value.

kedlas commented 11 months ago

The merge sync is the reason why the default value is 3. I would prefer to have the default value 0 (disabled), but for that we must have all ourt consymers ready in advance. This change proposed does not change any configuration which we currently use.

prochac commented 11 months ago

The merge sync is the reason why the default value is 3. I would prefer to have the default value 0 (disabled), but for that we must have all ourt consymers ready in advance. This change proposed does not change any configuration which we currently use.

OK, let's migrate our code to explicitly use 3, or better, make it configurable by env, and later we can make the breaking change, as it's only us using this module so far :D