search

datadesk / census-data-aggregator

Combine U.S. census data responsibly
MIT License
42 stars 9 forks source link

Approx percent change #9

Closed sastoudt closed 5 years ago

sastoudt commented 5 years ago

I Python'd!

Addressing: https://github.com/datadesk/census-data-aggregator/issues/8

The ACS General Handbook doesn't provide a numerical example for this calculation, so I'm not sure what we want to use as a test/example.

I also fixed a number in the approximate_ratio example (there was a duplicate).

palewire commented 5 years ago

TravisCI is raising some flake8 issues.

flake8 census_data_aggregator
census_data_aggregator/__init__.py:351:1: E302 expected 2 blank lines, found 1
census_data_aggregator/__init__.py:354:1: W293 blank line contains whitespace
census_data_aggregator/__init__.py:369:1: W191 indentation contains tabs
census_data_aggregator/__init__.py:369:1: E101 indentation contains mixed spaces and tabs
census_data_aggregator/__init__.py:370:1: W191 indentation contains tabs
census_data_aggregator/__init__.py:370:1: W293 blank line contains whitespace
census_data_aggregator/__init__.py:371:1: E101 indentation contains mixed spaces and tabs
census_data_aggregator/__init__.py:372:1: W293 blank line contains whitespace
census_data_aggregator/__init__.py:373:5: W191 indentation contains tabs
census_data_aggregator/__init__.py:373:5: E101 indentation contains mixed spaces and tabs
census_data_aggregator/__init__.py:377:1: W293 blank line contains whitespace
census_data_aggregator/__init__.py:396:1: W391 blank line at end of file
census_data_aggregator/__init__.py:396:1: W293 blank line contains whitespace
make: *** [test] Error 1
The command "make test" exited with 2.

You can run make test on your terminal to replicate this. Each style violation will need to be corrected before the tests pass.