Base class overrides the subclasses file paths

datadesk / python-elections

A Python wrapper for the Associated Press' U.S. election data service.

python-elections.rtfd.org

176 stars 46 forks source link

Base class overrides the subclasses file paths #55

Closed coordt closed 12 years ago

coordt commented 12 years ago

Both subclasses of BaseAPResultCollection call "super" after defining the file paths. BaseAPResultCollection then defines the file paths again. You won't see it in the state results, but will in the TopOfTicket results

Simply removing those lines as in : https://github.com/coordt/python-elections/commit/f904e67f7b917fac24903862c4fc6a063eeb79af is my fix.

Corey

palewire commented 12 years ago

I'm not seeing those lines in the current master branch, https://github.com/datadesk/python-elections/blob/master/elections/ap.py#L260

Could it be that we're out of sync?

coordt commented 12 years ago

You're right! I was certain that I had merged your latest stuff. Sorry about that.

palewire commented 12 years ago

Shit. Happens to me all the time. I still don't have the hang of git merge upstream/master and all that.