search

datadotworld / data.world-py

Python package for data.world
https://data.world/integrations/python
Apache License 2.0
102 stars 28 forks source link

PAPPY-277: Remove outdated file functionality (new PR) #133

Closed ddw-mike closed 2 years ago

ddw-mike commented 2 years ago

remove file upload functionality from update_dataset, replace_dataset, update_project, and replace_project; remove unnecessary parameter from build_dataset_obj and build_project_obj

Issue: https://dataworld.atlassian.net/browse/PAPPY-277

Re-creating this PR from https://github.com/datadotworld/data.world-py/pull/132 because it was easier than re-reverting the swagger changes

ddw-mike commented 2 years ago

@jonaf I looked into the Project Service Implementation code and found no functionality for files (uploads or URLs) in replaceProject. Therefore I've re-removed that functionality from the equivalent Python method, and I've submitted an intake ticket to amend that part of the documentation. On the downside, the PR is still failing the CircleCI build, and as far as I can tell (without diving into the minutia of the python test process), the method overloading is causing the failure - we may have to use dummy lambdas until the SDK can receive a proper update.

jonaf commented 2 years ago

@ddw-mike it looks like the failure is actually just a PEP8 linter claiming that some of the methods aren't in use. Did you update the call sites?