search

datadotworld / data.world-py

Python package for data.world
https://data.world/integrations/python
Apache License 2.0
102 stars 28 forks source link

Insights, project and new user API update #90

Closed gbolly closed 6 years ago

gbolly commented 6 years ago

@rflprr - This PR update the SDK with the new API endpoints for Insights, Projects and UserAPIs for fetch_contributing_projects, fetch_liked_projects and fetch_projects. It also updates the README file.

rflprr commented 6 years ago

Issues addressed with https://github.com/datadotworld/data.world-py/pull/90/commits/f00df3dbdcc09353827b18b58c056fbd509952a8

  1. Design consistency:
    1. Update/Replace/Delete methods should not return values
    2. Payloads should be passed as **kwargs and the concept of body should not leak from swagger auto-generated into data.world functions
    3. Request and response payloads should have properties named consistently (e.g. image_url instead of imageUrl)
  2. Bugs:
    1. Doctests were broken
    2. Required attributes were missing in constructors passed to __build_dataset_obj, __build_project_obj and __build_insight_obj
    3. linked_datasets parameter was improperly implemented in wrapper functions for projects
    4. source_link and data_source_links parameters were improperly implemented in wrapper functions for insights
    5. replace_project was broken
    6. add_linked_dataset was broken
  3. Documentation:
    1. Fixed docs for license field