Open godofdream opened 5 months ago
Hi @godofdream,
thanks for your contribution. please change also the tests, so we can be sure that the privileges are possible.
kind regards André
@CodiumAI-Agent /review
⏱️ Estimated effort to review [1-5] | 2 |
🧪 Relevant tests | Yes |
🔒 Security concerns | No |
⚡ Key issues to review |
Possible Bug: The addition of the "ALL" action in various resources might be intended to represent a wildcard for all actions. However, it's important to ensure that this does not unintentionally grant more permissions than expected. It's recommended to verify the implementation logic behind handling the "ALL" action to ensure it behaves as intended without security risks. |
@CodiumAI-Agent /review
@anmoel Hey I extended the tests.
@CodiumAI-Agent /review
Hi @godofdream,
the acceptance tests seem to fail because of actions that do not exist. You can run the acceptance tests locally to verify your changes, please check the readme at: https://github.com/datadrivers/terraform-provider-nexus?tab=readme-ov-file#testing and resolve the issues.
Thank you for the contribution.
Regards Chris
while trying to import all my priviledges I stumbled about missing allowed actions.