datadrivers / terraform-provider-nexus

Terraform provider for Sonatype Nexus
https://registry.terraform.io/providers/datadrivers/nexus
Mozilla Public License 2.0
119 stars 53 forks source link

Add missing actions #454

Open godofdream opened 5 months ago

godofdream commented 5 months ago

while trying to import all my priviledges I stumbled about missing allowed actions.

anmoel commented 5 months ago

Hi @godofdream,

thanks for your contribution. please change also the tests, so we can be sure that the privileges are possible.

kind regards André

godofdream commented 5 months ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 5 months ago

PR Reviewer Guide 🔍

(Review updated until commit https://github.com/datadrivers/terraform-provider-nexus/commit/2e6847068fcc19f2683c1142642cc08f079a067a)

⏱️ Estimated effort to review [1-5] 2
🧪 Relevant tests Yes
🔒 Security concerns No
⚡ Key issues to review Possible Bug:
The addition of the "ALL" action in various resources might be intended to represent a wildcard for all actions. However, it's important to ensure that this does not unintentionally grant more permissions than expected. It's recommended to verify the implementation logic behind handling the "ALL" action to ensure it behaves as intended without security risks.
godofdream commented 5 months ago

@CodiumAI-Agent /review

godofdream commented 5 months ago

@anmoel Hey I extended the tests.

CodiumAI-Agent commented 5 months ago

Persistent review updated to latest commit https://github.com/datadrivers/terraform-provider-nexus/commit/0bfb45c07fbec63c1cc4b91b29f97be01a83abca

godofdream commented 5 months ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 5 months ago

Persistent review updated to latest commit https://github.com/datadrivers/terraform-provider-nexus/commit/2e6847068fcc19f2683c1142642cc08f079a067a

chris-ruecker commented 4 months ago

Hi @godofdream,

the acceptance tests seem to fail because of actions that do not exist. You can run the acceptance tests locally to verify your changes, please check the readme at: https://github.com/datadrivers/terraform-provider-nexus?tab=readme-ov-file#testing and resolve the issues.

Thank you for the contribution.

Regards Chris