search

datadryad / dryad-product-roadmap

Repository of issues for Dryad project boards
https://github.com/orgs/datadryad/projects
8 stars 0 forks source link

Remove spaces/punctuation from entered keywords #3054

Closed bryanmgee closed 3 weeks ago

bryanmgee commented 8 months ago

Authors sometimes add keywords with a space or a period at the end (likely copied + pasted in from somewhere else). This has been less of an issue since restricting the displayed suggestions to the controlled vocabulary but still occurs when people freeform enter their own.

ryscher commented 7 months ago

Fixed by https://github.com/CDL-Dryad/dryad-app/pull/1479

DragosIorgulescu commented 7 months ago

We need to remove punctuation from keywords as well

ahamelers commented 7 months ago

We need to remove punctuation from keywords as well

@DragosIorgulescu Currently if someone includes ',' or ';' entering keywords in the frontend, that triggers the division of what is entered into multiple keywords (the string Testing, Keyword, Insertion becomes an array with items Testing, Keyword, Insertion); you may need to be careful about the order of operations to keep that intact.

alinvetian commented 2 months ago

@ahamelers I think we should remove all punctuation signs from the beginning AND ending of each tag/keyword. What do you think?

lauradryad commented 1 month ago

This fix has caused an issue where we cannot end a keyword with a closing parenthesis: image

Audrey says: there should probably have been a carveout for brackets or a check for opening ones

ahamelers commented 1 month ago

@lauradryad is the preferred solution to allow brackets, or to treat brackets as we treat commas (breaking the keyword into 2 there, species-area relationship and SAR)?

lauradryad commented 1 month ago

We would like to treat brackets like commas, breaking it into two keywords, please @ahamelers

alinvetian commented 1 month ago

aa (ss) dd text will be converted in 3 keywords aa, ss and dd