search

datadvance / DjangoChannelsGraphqlWs

Django Channels based WebSocket GraphQL server with Graphene-like subscriptions
MIT License
281 stars 84 forks source link

Django Requirements #77

Closed matclayton closed 1 year ago

matclayton commented 3 years ago

Channels 3.x works with Django 2.2+ as seen here (https://github.com/django/channels/blob/main/setup.py#L16)

However DjangoChannelsGraphqlWs requires Django >3, it would be better to align these to Django >2.2 and allow maximal flexibility.

For example we are upgrading on Django 2.2 from Channels 1->3, which should be doable, except for the requirements in DjangoChannelsGraphqlWs (https://github.com/datadvance/DjangoChannelsGraphqlWs/blob/master/pyproject.toml#L56), which I dont believe is a necessary restriction, as I can't see anything in this repro whic would need Django 3.x

Luferov commented 2 years ago

Also, Django 4.0 is released!

tony commented 2 years ago

77 will do it.

Will make another PR for django 4.0, issue at #82

Luferov commented 2 years ago

It will be good!

tony commented 2 years ago

@Luferov

PRs:

prokher commented 1 year ago

A new version 1.0.0rc is available on PyPI. It supports both the latest Django and the latest Graphene. Closing this. Feel free to reopen or file a new issue in case of problems.