search

datadvance / DjangoChannelsGraphqlWs

Django Channels based WebSocket GraphQL server with Graphene-like subscriptions
MIT License
281 stars 84 forks source link

Django 4.0 support, loosen version constraints #83

Open tony opened 2 years ago

tony commented 2 years ago

Fixes #82

tony commented 2 years ago

@datadvance Can you take a look at this PR for Django 4.0 support please?

Luferov commented 2 years ago

@prokher could you check PR and accept. Thanks!

tony commented 2 years ago

@datadvance Please give this a look if you can!

danielknightgaynor commented 2 years ago

@datadvance I'd also appreciate this being reviewed/merged :+1:

tony commented 2 years ago

@datadvance any possibility you could take a look?

Luferov commented 2 years ago

Hey, @tony create you own library from this and push it to pypi.

helgihg commented 2 years ago

Any news on when this could be merged? I've looked through the changes and they're not that complicated. Django 4.0 has been out for almost a year now and 4.1 is already out.

Ronjea commented 2 years ago

It would be lovely to have this out as a package 🚀

boomdizz commented 1 year ago

Seeing these. Could someone provide an ETA for when support for the latest packages would be available?

django-channels-graphql-ws 0.9.1 requires channels<4,>=3, but you have channels 4.0.0 which is incompatible. django-channels-graphql-ws 0.9.1 requires Django<4,>=3, but you have django 4.1.2 which is incompatible. django-channels-graphql-ws 0.9.1 requires graphene<3.0,>=2.1, but you have graphene 3.1.1 which is incompatible.

boomdizz commented 1 year ago

Another dependency that likely needs to be updated:

  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/__init__.py", line 29, in <module>
    from .client import GraphqlWsClient, GraphqlWsResponseError
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/client.py", line 30, in <module>
    from .transport import GraphqlWsTransport
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/transport.py", line 31, in <module>
    from . import graphql_ws_consumer
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/graphql_ws_consumer.py", line 57, in <module>
    import graphql.execution.executors.asyncio
ModuleNotFoundError: No module named 'graphql.execution.executors'