dataesr / react-dsfr

Non-official React components of the official french Système de Design de l'État.
https://dataesr.github.io/react-dsfr/
MIT License
44 stars 22 forks source link

add typescript support #207

Closed adipasquale closed 2 years ago

adipasquale commented 2 years ago

👋 FYI I'm starting a repository with typescript types definitions there: https://github.com/adipasquale/react-dsfr-types if anyone wants to contribute, they are welcome to :)

adipasquale commented 2 years ago

@ la team dataesr : would you be open to a PR that defines the TS types directly in this repo? the alternative being publishing to DefinitelyTyped but it seems to be a fallback option when the original repo is not open for PRs

poplingue commented 2 years ago

Hi @adipasquale, That would be super cool to have TS types in the repo. For now I have no time to contribute as developer but I'd be happy to make reviewing. Thanks again to participate with the project.

celiacheff commented 2 years ago

Another solution would be to rewrite the project using Typescript. Is this possible ? I can contribute if needed. Else, the solution proposed by @adipasquale could also be automated via the CI.

adipasquale commented 2 years ago

I opened up the PR #210 a few days ago, if someone can review it, I think it'd be a nice start :)

tchak commented 2 years ago

I want to help with TS port. Before doing any work, I have some questions:

marc-rutkowski commented 2 years ago

TS typing looks good (great work @adipasquale and @revolunet !) but is it possible to tag a new build of the module with the latest changes, so I can use it? Thanks for your help

revolunet commented 2 years ago

i think this issue can be closed; big up to @adipasquale for the initial effort :muscle: